Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13663 )
Change subject: IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java@79 PS3, Line 79: // Ranger plugin. do we need to reinit the ranger plugin for explicit REFRESH AUTHORIZATION calls? http://gerrit.cloudera.org:8080/#/c/13663/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationFactory.java@81 PS3, Line 81: authzChecker_ = new RangerAuthorizationChecker(authzConfig_); this isn't safe under concurrency unless authzChecker is volatile. Should we just initialize it in the constructor? -- To view, visit http://gerrit.cloudera.org:8080/13663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd5c1b5c7cafc7a03681def0c0f6f775d690c41 Gerrit-Change-Number: 13663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 17 Jun 2019 20:15:04 +0000 Gerrit-HasComments: Yes
