Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 )
Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13664/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/13664/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@442 PS2, Line 442: // We're not setting hit = true, so we're counting this case as a cache miss? I guess that makes sense in some way, since we'll be incurring some of the loading delay. Might be clearer if this was explained, maybe in a comment attached to "hit". Or maybe there's a better name for hit, like immediateHit. http://gerrit.cloudera.org:8080/#/c/13664/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@455 PS2, Line 455: boolean hit = false; Do we have tests for these exceptional code paths? Including the case when multiple threads end up getting the same exception. -- To view, visit http://gerrit.cloudera.org:8080/13664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70f377db88e204825a909389f28dc3451815235c Gerrit-Change-Number: 13664 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Jun 2019 20:40:55 +0000 Gerrit-HasComments: Yes
