Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13660 )
Change subject: IMPALA-8669 Support giving a terminal commit in compare_branches.py ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13660/1/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/13660/1/bin/compare_branches.py@105 PS1, Line 105: h > flake8: E128 continuation line under-indented for visual indent Ignored this to keep original code style http://gerrit.cloudera.org:8080/#/c/13660/1/bin/compare_branches.py@166 PS1, Line 166: > flake8: E302 expected 2 blank lines, found 1 Done -- To view, visit http://gerrit.cloudera.org:8080/13660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I7a4dfae26f8f616c6f550114edfbafd6fc1c068d Gerrit-Change-Number: 13660 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 18 Jun 2019 23:21:12 +0000 Gerrit-HasComments: Yes