Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13583 )
Change subject: IMPALA-7467: Port ExecQueryFInstances to krpc ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13583/2/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: http://gerrit.cloudera.org:8080/#/c/13583/2/be/src/runtime/backend-client.h@48 PS2, Line 48: /// Callers of TransmitData() should provide their own counter to measure the data : /// transmission time. : void SetTransmitDataCounter(RuntimeProfile::ConcurrentTimerCounter* csw) { : DCHECK(transmit_csw_ == NULL); : transmit_csw_ = csw; : } : : /// ImpalaBackendClient is shared by multiple queries. It's the caller's responsibility : /// to reset the counter after data transmission. : void ResetTransmitDataCounter() { : transmit_csw_ = NULL; : } > Not your change but I believe these are not needed anymore. May as well del Done http://gerrit.cloudera.org:8080/#/c/13583/2/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/13583/2/common/protobuf/control_service.proto@235 PS2, Line 235: 5 > Why the jump from 2 to 5 ? Done -- To view, visit http://gerrit.cloudera.org:8080/13583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3f1c6099109bd8e5361188005a7d0e892147570 Gerrit-Change-Number: 13583 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Jun 2019 23:26:28 +0000 Gerrit-HasComments: Yes
