Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13664 )

Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@243
PS4, Line 243:   final AtomicInteger piggybackSuccessCountForTests = new 
AtomicInteger();
> nit: final
Done


http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@250
PS4, Line 250:   final AtomicInteger piggybackExceptionCountForTests = new 
AtomicInteger();
> nit: final
Done


http://gerrit.cloudera.org:8080/#/c/13664/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@434
PS4, Line 434: returns an invalidation for the table name list
> just for my sake of understanding. Is the invalidate of table name done in
yea, because a table was created, the list of tables in that DB gets 
invalidated.



--
To view, visit http://gerrit.cloudera.org:8080/13664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70f377db88e204825a909389f28dc3451815235c
Gerrit-Change-Number: 13664
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2019 21:39:13 +0000
Gerrit-HasComments: Yes

Reply via email to