Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 )
Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/13386/8/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/13386/8/tests/common/environ.py@223 PS8, Line 223: def get_instance(cls): > This is a non-blocking comment, but but there's a bit of python pedantry/ha I think I will skip this one. http://gerrit.cloudera.org:8080/#/c/13386/8/tests/common/environ.py@321 PS8, Line 321: def _get_flags_from_web_ui(self): > Also non-blocking, but a style nit here: seems like this would be a good pl Done http://gerrit.cloudera.org:8080/#/c/13386/8/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/13386/8/tests/hs2/test_hs2.py@42 PS8, Line 42: handless > handles? Done -- To view, visit http://gerrit.cloudera.org:8080/13386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6b2a1391f53121d3d7c00c5cf0a57590899ce4 Gerrit-Change-Number: 13386 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Jun 2019 23:37:41 +0000 Gerrit-HasComments: Yes