Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13712 )
Change subject: IMPALA-8700: Use int64_t mtime for HdfsScanNodeBase::AllocateScanRange() ...................................................................... IMPALA-8700: Use int64_t mtime for HdfsScanNodeBase::AllocateScanRange() HDFS defines the modification time as the milliseconds since Jan 1st, 1970. Since milliseconds wrap every 49 days in a 4 byte integer, all locations storing modification time need to use an 8 byte integer. The overload of HdfsScanNodeBase::AllocateScanRange() that is called from Impala-lzo uses a 4 byte integer. When this wraps, it triggers a DCHECK in ScanRange::Reset() that assumes mtime > 0. This changes the HdfsScanNodeBase::AllocateScanRange() overload to take an int64_t. The Impala-lzo side already supplies an int64_t. Change-Id: Icce5b22361c74333f3213dce629e0e625550573f Reviewed-on: http://gerrit.cloudera.org:8080/13712 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icce5b22361c74333f3213dce629e0e625550573f Gerrit-Change-Number: 13712 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
