Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 )
Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt@57 PS2, Line 57: target_link_libraries(fesupport "-Wl,--whole-archive \ > Can you indent the code inside the if? We generally do this in CMake files. Done -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 03:53:19 +0000 Gerrit-HasComments: Yes
