Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13722 )
Change subject: IMPALA-8703: ISO:SQL:2016 datetime patterns - Milestone 1 ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/13722/1/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/13722/1/be/src/runtime/timestamp-test.cc@658 PS1, Line 658: TimestampValue::ParseSimpleDateFormat(test_case.str, strlen(test_case.str), dt_ctx); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@18 PS1, Line 18: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@410 PS1, Line 410: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@418 PS1, Line 418: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@548 PS1, Line 548: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@553 PS1, Line 553: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/13722/1/tests/query_test/test_cast_with_format.py@648 PS1, Line 648: " flake8: E225 missing whitespace around operator -- To view, visit http://gerrit.cloudera.org:8080/13722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19d8d097a45ae6f103b6cd1b2d81aad38dfd9e23 Gerrit-Change-Number: 13722 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 14:44:14 +0000 Gerrit-HasComments: Yes
