Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Thanks for fixing this, seems much simpler to follow. http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java File fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java: http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java@24 PS7, Line 24: public class DummyQueryEventHook implements QueryEventHook { Add a class comment on how this is supposed to work? http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py File tests/custom_cluster/test_query_event_hooks.py: http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py@112 PS7, Line 112: LOG.info(method.func_dict) remove? -- To view, visit http://gerrit.cloudera.org:8080/13713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470 Gerrit-Change-Number: 13713 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 16:40:08 +0000 Gerrit-HasComments: Yes
