Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 )
Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test ...................................................................... Patch Set 4: (3 comments) > Patch Set 1: > > (3 comments) http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@222 PS1, Line 222: // Skip cardinality validation because some tables do not have stats > This comment should be more concise. The comments shouldn't explain the cha Thanks for the prompt reply! I will modify the comment as suggested. http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@227 PS1, Line 227: @Test > No need to pass in an empty set when there's an overload that does not requ Sure. I will use the method that does not require this argument. http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@263 PS1, Line 263: public void testFkPkJoinDetectionWithHDFSNumRowsEstDisabled() { Thanks Tim! I have removed the cardinality validation here as well. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Jun 2019 00:37:50 +0000 Gerrit-HasComments: Yes
