Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13744 )

Change subject: IMPALA-8716: Log a group of privileges into a single audit 
event.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13744/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java
File 
fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java:

http://gerrit.cloudera.org:8080/#/c/13744/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@319
PS2, Line 319:  // so that we know all the audit events generated by the 
temporary audit
             :     // handler are contained to the given resource.
             :     RangerBufferAuditHandler tmpAuditHandler = 
originalAuditHandler == null ?
             :         null : new 
RangerBufferAuditHandler(originalAuditHandler);
             :     for (Privilege impliedPrivilege: privile
> I think you missed the comment.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53102bc1ceaf9d62544090dc00f3231fae0efca
Gerrit-Change-Number: 13744
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:41:32 +0000
Gerrit-HasComments: Yes

Reply via email to