Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13773 )
Change subject: [DOCS] \N needs to be escaped in Sqoop for Impala to recognize as null ...................................................................... Patch Set 1: (3 comments) What is the origin of this change? Did someone complain about this? http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@308 PS1, Line 308: <codeph>--null-string '\\N' <codeph>--null-non-string : '\\N'</codeph> On the commandline, there is a difference between single and double quotes: $ echo "\\N" \N $ echo '\\N' \\N In this case, I believe it should be either double quotes with the escaping or single quotes without the escaping. i.e. "\\N" or '\N' http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@392 PS1, Line 392: specify : to represent The "<codeph>\N</codeph>" in the old version got dropped, so this is currently: "specify to represent" I think it should be: "specify <codeph>\N</codeph> to represent" http://gerrit.cloudera.org:8080/#/c/13773/1/docs/topics/impala_txtfile.xml@394 PS1, Line 394: needs to be escaped as <codeph>'\\N'</codeph> when : used in a string. I'm a bit confused about what this is trying to get across. In the actual text file, it should be \N. Users can write text files several different ways. Some require escaping, some don't. I think I would rather leave this paragraph the way it was. -- To view, visit http://gerrit.cloudera.org:8080/13773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I581f532c2f865e93d8922661c389791f41805b64 Gerrit-Change-Number: 13773 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Jul 2019 18:10:14 +0000 Gerrit-HasComments: Yes
