Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13746 )
Change subject: IMPALA-8717: impala-shell support for HS2 HTTP endpoint ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/13746/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13746/4//COMMIT_MSG@17 PS4, Line 17: impala-shell --protocol='hs2-http' --ldap -u..... (PLAIN auth) > I kinda feel like we should be able to enable this with a single flag. That Good point. Makes it simpler. http://gerrit.cloudera.org:8080/#/c/13746/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/13746/4/be/src/service/impala-server.cc@2080 PS4, Line 2080: << " to server " << connection_context.server_name << " with " > I think it might still be useful to log the number of associated sessions e Done. Removed L2085 since we have "closing session" logs for each session anyway. http://gerrit.cloudera.org:8080/#/c/13746/4/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/13746/4/shell/impala_client.py@367 PS4, Line 367: if connect_timeout_ms > 0: > nit: prefer format(), e.g. Done http://gerrit.cloudera.org:8080/#/c/13746/4/shell/impala_client.py@377 PS4, Line 377: # THttpClient relies on the URI scheme (http vs https) to open an appropriate > Same comment about format() Done http://gerrit.cloudera.org:8080/#/c/13746/4/shell/impala_client.py@379 PS4, Line 379: if self.use_ssl: > Same comment about format() Done http://gerrit.cloudera.org:8080/#/c/13746/4/shell/impala_client.py@383 PS4, Line 383: else: > Same comment about format() Done -- To view, visit http://gerrit.cloudera.org:8080/13746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8323950857dfe1c1dfd5377fde79f87bc2ce9534 Gerrit-Change-Number: 13746 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jul 2019 06:24:20 +0000 Gerrit-HasComments: Yes
