Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2116 PS4, Line 2116: in Kudu that is integrated with Hive : Metastore. > nit: maybe rephrase, "...if the Kudu service is integrated with the Hive Me Done http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115 PS4, Line 2115: This : operation is not supported in Kudu that is integrated with Hive : Metastore. > We have been using the term "orphaned table" to refer to a Kudu table that @andrew So this statement is correct, right? http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115 PS4, Line 2115: This : operation is not supported in Kudu that is integrated with Hive : Metastore. > I don't think that this is correct. The design doc says that this applies t According to Andrew's comment, this is correct, no? http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116 PS4, Line 1116: <note>This section only applies the Kudu services that are not > This patch mostly just points out things that no longer apply. Is there an Added a section and a link to kudu doc. http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116 PS4, Line 1116: <note>This section only applies the Kudu services that are not > Upstream Kudu has just updated its docs to include both of these: Done http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml File docs/topics/impala_tables.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@289 PS4, Line 289: Some : information about the table is stored in the metastore database for use : by Impala. Other table metadata is managed internally by Kudu. > Actually all data that Impala needs is stored in the HMS (including things Changed to: All data that Impala needs is stored in the HMS. http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@293 PS4, Line 293: <p> : In the Kudu services enabled to use Hive Metastore (HMS), all metadata : is managed by HMS. : </p> > This isn't quite right. Mostly it's managed by Kudu. Some Impala-specific t Done http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336 PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix > Maybe move this up to be directly after the paragraph that talks about '::' Done http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336 PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/13776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e Gerrit-Change-Number: 13776 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Jul 2019 02:15:03 +0000 Gerrit-HasComments: Yes
