Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13874 )
Change subject: IMPALA-8606: Don't load table meta for GET_TABLES in local catalog mode ...................................................................... Patch Set 5: (2 comments) Couple of nits, but can +2 once fixed. http://gerrit.cloudera.org:8080/#/c/13874/5/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/13874/5/fe/src/main/java/org/apache/impala/catalog/Catalog.java@167 PS5, Line 167: Catalog v1 > I'm trying to explain why the implementation here is just delegating to get Right, I'm talking about the terminology. In the code, we never see these terms like v1 and v2. Maybe say legacy implementation vs LocalCatalog implementation or some such thing? http://gerrit.cloudera.org:8080/#/c/13874/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/13874/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@385 PS6, Line 385: Why this -- To view, visit http://gerrit.cloudera.org:8080/13874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8bbab7efdf8e629abe09d89ae3bd770e3feaccb Gerrit-Change-Number: 13874 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 19 Jul 2019 16:16:52 +0000 Gerrit-HasComments: Yes
