Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 )
Change subject: IMPALA-5149: Provide query profile in JSON format ...................................................................... Patch Set 8: Code-Review+1 (5 comments) Some minor comments, but generally looks good to me. I spoke to Michael Ho offline who is going to take another look into the change and take it to a +2. Thanks for your patience so far. http://gerrit.cloudera.org:8080/#/c/13801/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13801/8//COMMIT_MSG@22 PS8, Line 22: Add a section on future compatibility guarantees? I think the idea is that this can evolve over time until we standardize the counters and the profile structure. So, until then if there are some Impal a changes, clients can expect the JSON structure to change too (keys could be added, deleted etc.) http://gerrit.cloudera.org:8080/#/c/13801/8/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/13801/8/be/src/util/runtime-profile-counters.h@292 PS8, Line 292: val->RemoveMember("kind"); Should we not update the kind ? Why remove it? http://gerrit.cloudera.org:8080/#/c/13801/8/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/13801/8/tests/hs2/test_hs2.py@668 PS8, Line 668: json_res["contents"]["child_profiles"][0]["info_strings"]: This looks flaky. Instead assert that they exist before you can loop through them? http://gerrit.cloudera.org:8080/#/c/13801/8/tests/hs2/test_hs2.py@670 PS8, Line 670: assert statement in info_string["value"] dump the json_res if the assert fails, helps with debugging test failures. http://gerrit.cloudera.org:8080/#/c/13801/8/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13801/8/tests/webserver/test_web_pages.py@594 PS8, Line 594: self.fail("Download JSON format query profile cannot be parsed.") dump json -- To view, visit http://gerrit.cloudera.org:8080/13801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8181ac818bf22207ca1deabd9220c397ae723ec1 Gerrit-Change-Number: 13801 Gerrit-PatchSet: 8 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jul 2019 17:20:25 +0000 Gerrit-HasComments: Yes