Joe McDonnell has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13515 )
Change subject: IMPALA-8176: Convert simple backend tests to the unified executable ...................................................................... IMPALA-8176: Convert simple backend tests to the unified executable This converts tests with trivial main() functions to the unified executable. This means that the code change is strictly removing main() functions and updating the CMakeLists.txt files. Any test that requires a change larger than that will be addressed separately. The only exceptions are: - exec/incr-stats-util-test.cc requires naming changes to avoid conflicts with util/rle-test.cc - runtime/decimal-test.cc simplified the naming to make the CMakeLists.txt arguments easier. The new test libraries are marked STATIC, because they are linked into a single binary (unifiedbetests) and googletest has problems with tests in shared libraries. Converting this set of tests saves about 18GB of disk space for a debug build and saves a minute or two of link time. For any CMakeLists.txt that has unified tests, this adds a comment for each test that is not unified. Testing: - Ran backend tests in DEBUG and ASAN modes on Centos7 - Ran backend tests in DEBUG mode on Centos6 Change-Id: I840d0f9b70edb3a7195a2a33b21fd2874d4c52bd --- M be/CMakeLists.txt M be/src/catalog/CMakeLists.txt M be/src/catalog/catalog-util-test.cc M be/src/codegen/CMakeLists.txt M be/src/codegen/instruction-counter-test.cc M be/src/common/CMakeLists.txt M be/src/common/atomic-test.cc M be/src/common/thread-debug-info-test.cc M be/src/exec/CMakeLists.txt M be/src/exec/delimited-text-parser-test.cc M be/src/exec/hash-table-test.cc M be/src/exec/hdfs-avro-scanner-test.cc M be/src/exec/incr-stats-util-test.cc M be/src/exec/parquet/CMakeLists.txt M be/src/exec/parquet/hdfs-parquet-scanner-test.cc M be/src/exec/parquet/parquet-bool-decoder-test.cc M be/src/exec/parquet/parquet-common-test.cc M be/src/exec/parquet/parquet-page-index-test.cc M be/src/exec/parquet/parquet-plain-test.cc M be/src/exec/parquet/parquet-version-test.cc M be/src/exec/read-write-util-test.cc M be/src/exec/zigzag-test.cc M be/src/exprs/CMakeLists.txt M be/src/exprs/expr-test.cc M be/src/exprs/timezone_db-test.cc M be/src/gutil/CMakeLists.txt M be/src/rpc/CMakeLists.txt M be/src/rpc/thrift-util-test.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/bufferpool/CMakeLists.txt M be/src/runtime/bufferpool/free-list-test.cc M be/src/runtime/bufferpool/suballocator-test.cc M be/src/runtime/date-test.cc M be/src/runtime/decimal-test.cc M be/src/runtime/free-pool-test.cc M be/src/runtime/hdfs-fs-cache-test.cc M be/src/runtime/io/CMakeLists.txt M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/mem-pool-test.cc M be/src/runtime/mem-tracker-test.cc M be/src/runtime/multi-precision-test.cc M be/src/runtime/raw-value-test.cc M be/src/runtime/row-batch-serialize-test.cc M be/src/runtime/string-buffer-test.cc M be/src/runtime/string-compare-test.cc M be/src/runtime/string-search-test.cc M be/src/runtime/string-value-test.cc M be/src/runtime/thread-resource-mgr-test.cc M be/src/runtime/timestamp-test.cc M be/src/runtime/tmp-file-mgr-test.cc M be/src/scheduling/CMakeLists.txt M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/cluster-membership-mgr-test.cc M be/src/scheduling/executor-group-test.cc M be/src/scheduling/hash-ring-test.cc M be/src/scheduling/scheduler-test.cc M be/src/service/CMakeLists.txt M be/src/service/hs2-util-test.cc M be/src/service/impala-server-test.cc M be/src/service/query-options-test.cc M be/src/util/CMakeLists.txt 61 files changed, 190 insertions(+), 188 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/13515/6 -- To view, visit http://gerrit.cloudera.org:8080/13515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I840d0f9b70edb3a7195a2a33b21fd2874d4c52bd Gerrit-Change-Number: 13515 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
