Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13860 )
Change subject: IMPALA-8489: Partitions created by RECOVER PARTITIONS fail to create insert events with IllegalStateException. ...................................................................... Patch Set 2: (1 comment) Latest patch looks good to me. I think since this bug can be reproduced reliably, it would be great we should add a test to existing python test for inserts. http://gerrit.cloudera.org:8080/#/c/13860/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13860/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3868 PS2, Line 3868: affectedExistingPartitions I think it is more readable if you rename this to partitionsBeforeInsert or partsBeforeInsert -- To view, visit http://gerrit.cloudera.org:8080/13860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idef7f6aadff2868047c861ebfcc05d65f080eab9 Gerrit-Change-Number: 13860 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jul 2019 21:43:24 +0000 Gerrit-HasComments: Yes
