Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13740 )
Change subject: [WIP] IMPALA-7486: Prototype for admitting less mem on coord ...................................................................... Patch Set 6: (1 comment) Fixed a couple of bugs that were shown up by test_insert.py http://gerrit.cloudera.org:8080/#/c/13740/5/be/src/scheduling/query-schedule.cc File be/src/scheduling/query-schedule.cc: http://gerrit.cloudera.org:8080/#/c/13740/5/be/src/scheduling/query-schedule.cc@308 PS5, Line 308: && per_backend_exec_params_.begin()->second.contains_coord_fragment) { This isn't quite right - a counterexample is an insert query that is only scheduled to run on a single node. -- To view, visit http://gerrit.cloudera.org:8080/13740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b94e7293b91dec8a18491079c34923eadd94b21 Gerrit-Change-Number: 13740 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 20 Jul 2019 07:13:53 +0000 Gerrit-HasComments: Yes
