Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13870 )
Change subject: IMPALA-8752: Added Jaro-Winkler edit distance and similarity built-in function ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/13870/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13870/1/be/src/exprs/string-functions-ir.cc@1190 PS1, Line 1190: if (s1len == s2len && memcmp(s1.ptr, s2.ptr, s1len) == 0) return DoubleVal(1.0); : if (s1len == 0) return DoubleVal(0.0); > I think my previous comment got forgotten. Done -- To view, visit http://gerrit.cloudera.org:8080/13870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64d7f461516c5e66cc27d62612bc8cc0e8f0178c Gerrit-Change-Number: 13870 Gerrit-PatchSet: 7 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Jul 2019 11:41:30 +0000 Gerrit-HasComments: Yes
