Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13740 )
Change subject: [WIP] IMPALA-7486: Prototype for admitting less mem on coord ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/13740/11/www/admission_controller.tmpl File www/admission_controller.tmpl: http://gerrit.cloudera.org:8080/#/c/13740/11/www/admission_controller.tmpl@275 PS11, Line 275: <th>Memory limit for the coordinator</th> : <th>Memory admitted on the coordinator</th> : <th>Num of backends it will run on</th> : <th>Details</th> : </tr> : {{#queued_queries}} : <tr> : <td>{{query_id}}</td> : <th>Memory limit for the executors</th> : <th>Memory admitted on the executors</th> : <td class='memory'>{{coord_backend_mem_limit}}</td> : <td class='memory'>{{coord_backend_mem_to_admit}}</td> This looks wrong (noticed when trying the change on a real cluster) -- To view, visit http://gerrit.cloudera.org:8080/13740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b94e7293b91dec8a18491079c34923eadd94b21 Gerrit-Change-Number: 13740 Gerrit-PatchSet: 11 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Jul 2019 05:11:47 +0000 Gerrit-HasComments: Yes
