Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13906 )
Change subject: IMPALA-8615: [DOCS] Document the scalable admission control parameters ...................................................................... Patch Set 2: (1 comment) This basically looks good, one thing caught my attention http://gerrit.cloudera.org:8080/#/c/13906/2/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: http://gerrit.cloudera.org:8080/#/c/13906/2/docs/topics/impala_admission.xml@114 PS2, Line 114: This setting : scales with the number of hosts in the resource pool. Instead of 'hosts' I think you should say 'executors', to be consistent. Does the setting scale? I would say something like 'The effect of this setting scales with...' -- To view, visit http://gerrit.cloudera.org:8080/13906 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibca9cf9586359ee0f1ce0dd8744b4709752a26f1 Gerrit-Change-Number: 13906 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jul 2019 16:54:58 +0000 Gerrit-HasComments: Yes
