Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 )
Change subject: IMPALA-8785: give debug docker images a different name ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13905/5/docker/CMakeLists.txt File docker/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13905/5/docker/CMakeLists.txt@62 PS5, Line 62: Docker does not support : # variables in the FROM clause > It does work for me now, wonder what I did wrong first time. Before I go ba The build args would handle the build_type stuff in this change. I think it could potentially handle IMPALA-8770. I would maybe lean towards using the build args for now. Even so, I don't think I have strong preferences one way or the other. The templating isn't that bad in terms of complexity. -- To view, visit http://gerrit.cloudera.org:8080/13905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d2e19cb671beacceebb2642aba01191bd7a244 Gerrit-Change-Number: 13905 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jul 2019 18:07:29 +0000 Gerrit-HasComments: Yes
