Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13893 )
Change subject: IMPALA-8772: Import Testcase failed for SQL without table refs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13893/2/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/13893/2/tests/metadata/test_testcase_builder.py@51 PS2, Line 51: status = call(["hdfs", "dfs", "-rm", "-skipTrash", testcase_path[1: -1]]) : assert status == 0, "Delete generated testcase file failed with {0}".format(status) you can use delete_file_dir from hdfs_util.py . Also please put it in a finally block. (to make sure the deletion happens regardless of test case export failures). -- To view, visit http://gerrit.cloudera.org:8080/13893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50d77d7de44bb140598a1e8db4da85a5ec87f31e Gerrit-Change-Number: 13893 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jul 2019 01:02:22 +0000 Gerrit-HasComments: Yes
