Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml
File docs/topics/impala_parquet_write_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@48
PS3, Line 48:     <p>
            :       This option enables the same optimization as the 
<codeph>PARQUET_READ_STATISTICS</codeph>
            :       for writing at the finer grained page level.
            :     </p>
> This option is only about writing, so this paragraph doesn't belong here.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@62
PS3, Line 62:       <li>
            :         For simple predicates of the forms: <codeph>&lt;slot> 
&lt;op> &lt;constant></codeph> or
            :         <codeph>&lt;constant> &lt;op> &lt;slot></codeph>, where 
<codeph>&lt;op></codeph> is LT,
            :         LE, GE, GT, and EQ
            :       </li>
> This isn't really belong to the write path.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@73
PS3, Line 73: Read statistics from Parquet pages and use
            :           them in query processing.
> Write the Parquet page index when creating Parquet files.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@78
PS3, Line 78:  Do not use Parquet write page statistics.
> Do not write the Parquet page index when creating Parquet files.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 22:49:23 +0000
Gerrit-HasComments: Yes

Reply via email to