Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 )
Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/13559/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13559/15//COMMIT_MSG@17 PS15, Line 17: The write id is also set the for the HDFS table sinks. The sinks write the : files at their final destination which is an ACID base or delta directory. > nit: please wrap at 72 Done http://gerrit.cloudera.org:8080/#/c/13559/15/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/13559/15/be/src/service/client-request-state.cc@1116 PS15, Line 1116: Status debug_action_status = DebugAction( : query_options(), "CLIENT_REQUEST_UPDATE_CATALOG"); : Status status = !debug_action_status.ok() ? debug_action_status : : client.DoRpc( : &CatalogServiceClientWrapper::UpdateCatalog, catalog_update, &resp); > nit: could be bit simpler IMO as Done http://gerrit.cloudera.org:8080/#/c/13559/15/testdata/workloads/functional-query/queries/QueryTest/acid-insert-fail.test File testdata/workloads/functional-query/queries/QueryTest/acid-insert-fail.test: http://gerrit.cloudera.org:8080/#/c/13559/15/testdata/workloads/functional-query/queries/QueryTest/acid-insert-fail.test@1 PS15, Line 1: ==== > It would be also useful to test (dynamic) partitioned inserts with differen Done -- To view, visit http://gerrit.cloudera.org:8080/13559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c36fa6902676f06b4e38730f737becfc7c06ad Gerrit-Change-Number: 13559 Gerrit-PatchSet: 15 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jul 2019 15:56:48 +0000 Gerrit-HasComments: Yes
