Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13765 )
Change subject: IMPALA-8718: Fixed AnalysisException in inline view with outer join complex type column ...................................................................... Patch Set 5: (1 comment) Sorry that it takes time for me to examine all the code paths in the Planner side. This patch makes sense to me. But I need to go deeper to make sure whether this is the best place to add an If-statement for this case. http://gerrit.cloudera.org:8080/#/c/13765/5/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java File fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java: http://gerrit.cloudera.org:8080/#/c/13765/5/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java@163 PS5, Line 163: // If the expr is a complex type, return false directly because I think we need to explain why the return type of an expression can be in complex type. In this case the expression is a SlofRef for a complex type column. It's produced by the SubPlan node. In the case of "count(*)", there're no IllegalStateException even without this patch. The reason is that AggregateInfo will generate intermediate TupleDescriptor which doesn't contain the complex type SlotRef. Some relative JIRAs: IMPALA-2875, IMPALA-2138 -- To view, visit http://gerrit.cloudera.org:8080/13765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida65503ca4b1342b8fe0049753bc664da227dca9 Gerrit-Change-Number: 13765 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Jul 2019 21:06:32 +0000 Gerrit-HasComments: Yes
