Sharanitha Harish has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13952


Change subject: IMPALA-8761 Configuration validation introduced in IMPALA-8559 
can be improved
......................................................................

IMPALA-8761 Configuration validation introduced in IMPALA-8559 can be improved

This patch aims to improve the validation of configuration keys from the 
metastore server.

The issue with configuration validation in IMPALA-8559 is that it validates one 
configuration
at a time and fails as soon as there is a validation error. Since there are 
more than one
configuration keys to validate, user may have to restart HMS again and again if 
there are
multiple configuration changes which are needed. This is not a great user 
experience.
This patch presents  all of the incorrect configuration validations and results 
together
in case of failures so that user can change all the required changes in one go.

Added a test testValidateConfigs() to assert if multiple incorrect values are 
thrown
together according the MetastoreShim.getMajorVersion().

Change-Id: I52d07bce88f9332a34bfe2f9b31570203485d544
---
M 
fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 28 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/13952/1
--
To view, visit http://gerrit.cloudera.org:8080/13952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52d07bce88f9332a34bfe2f9b31570203485d544
Gerrit-Change-Number: 13952
Gerrit-PatchSet: 1
Gerrit-Owner: Sharanitha Harish <sharanitha.har...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>

Reply via email to