Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13932 )

Change subject: IMPALA-8661 : Add randomized tests to stress 
MetastoreEventsProcessor
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1343
PS4, Line 1343:           // when multiple partitions are added in HMS they are 
all added as one transaction
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
File fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java:

http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java@142
PS4, Line 142:     return createClient(TestUtils.HIVE_SERVER2_DRIVER_NAME, 
getNoAuthConnectionStr("binary"));
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java@150
PS4, Line 150:     return createClient(TestUtils.HIVE_SERVER2_DRIVER_NAME, 
getNoAuthConnectionStr("http"));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java
File fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java:

http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java@838
PS4, Line 838:          query.addDependentQuery(new 
SetConfigStmt("tez.session.am.dag.submit.timeout.secs", "2"));
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/13932/4/fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java@918
PS4, Line 918:          query.addDependentQuery(new 
SetConfigStmt("tez.session.am.dag.submit.timeout.secs", "2"));
line too long (99 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/13932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c85b83efd4f56b5ae0e8d1dc6a2ee2feb6721ce
Gerrit-Change-Number: 13932
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jul 2019 06:20:59 +0000
Gerrit-HasComments: Yes

Reply via email to