Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13905 )
Change subject: IMPALA-8785: give debug docker images a different name ...................................................................... Patch Set 9: (3 comments) This makes sense. A couple small comments http://gerrit.cloudera.org:8080/#/c/13905/9/.gitignore File .gitignore: http://gerrit.cloudera.org:8080/#/c/13905/9/.gitignore@47 PS9, Line 47: docker/catalogd/Dockerfile : docker/statestored/Dockerfile : docker/impalad*/Dockerfile I think we need to remove these http://gerrit.cloudera.org:8080/#/c/13905/9/docker/CMakeLists.txt File docker/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13905/9/docker/CMakeLists.txt@22 PS9, Line 22: target build Nit: "target to build" http://gerrit.cloudera.org:8080/#/c/13905/9/docker/CMakeLists.txt@63 PS9, Line 63: Docker does not support : # variables in the FROM clause, so some kind of templating is needed. Using sed feels : # like a hack, but is an accepted practice for generating Dockerfiles. This comment is stale now that we are using build args. -- To view, visit http://gerrit.cloudera.org:8080/13905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d2e19cb671beacceebb2642aba01191bd7a244 Gerrit-Change-Number: 13905 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jul 2019 14:31:12 +0000 Gerrit-HasComments: Yes
