Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 )
Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/13907/7/tests/query_test/test_result_spooling.py File tests/query_test/test_result_spooling.py: http://gerrit.cloudera.org:8080/#/c/13907/7/tests/query_test/test_result_spooling.py@72 PS7, Line 72: class TestResultSpoolingCancellation(ImpalaTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13907/7/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/13907/7/tests/util/cancel_util.py@79 PS7, Line 79: def __fetch_results(): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13907/7/tests/util/cancel_util.py@84 PS7, Line 84: q > flake8: F821 undefined name 'query' Done http://gerrit.cloudera.org:8080/#/c/13907/7/tests/util/cancel_util.py@84 PS7, Line 84: h > flake8: F821 undefined name 'handle' Done -- To view, visit http://gerrit.cloudera.org:8080/13907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283 Gerrit-Change-Number: 13907 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Aug 2019 22:02:54 +0000 Gerrit-HasComments: Yes