Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13857 )
Change subject: IMPALA-8549: Add support for scanning DEFLATE text files ...................................................................... Patch Set 6: > Patch Set 6: Code-Review+1 > > (3 comments) > > The code looks good to me. Did you do any interop tests, e.g. create .deflate > files with Hive and read them with Impala? Thanks for reviewing Zoltan. Yes, there is an interop test in test_compressed_formats.py called test_compressed_formats that uses the test tables in Impala to read compressed files of various formats created in Hive. -- To view, visit http://gerrit.cloudera.org:8080/13857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a Gerrit-Change-Number: 13857 Gerrit-PatchSet: 6 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Aug 2019 17:34:42 +0000 Gerrit-HasComments: No
