Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 )
Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py File tests/query_test/test_result_spooling.py: http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py@26 PS10, Line 26: tpch > tpch_parquet? Done http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py@39 PS10, Line 39: v.get_value('table_format').file_format == 'parquet') > Do we want to run it for all file formats in exhaustive? I think it makes s Done http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py@46 PS10, Line 46: self.run_test_case('QueryTest/result-spooling', vector) > Most or all of the queries explicitly specify "functional", which is text, Done http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py@58 PS10, Line 58: result = self.execute_query(query, exec_options) > Maybe make a copy of exec_options, it's a little surprising that this funct Done http://gerrit.cloudera.org:8080/#/c/13907/10/tests/query_test/test_result_spooling.py@96 PS10, Line 96: v.get_value('table_format').file_format == 'parquet' and > The same nit applies here that you've specified parquet but are querying te Changed all the queries to use 'tpch_parquet' so this should be fixed now. -- To view, visit http://gerrit.cloudera.org:8080/13907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b3a1539c4a5fa9b43c8ca315cea16c9701e283 Gerrit-Change-Number: 13907 Gerrit-PatchSet: 10 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Aug 2019 20:30:29 +0000 Gerrit-HasComments: Yes
