Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14012 )
Change subject: IMPALA-4551: Limit the size of SQL statements ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14012/1/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/14012/1/tests/query_test/test_exprs.py@147 PS1, Line 147: test_max_statement_size Thinking of adding an assert verifying that this takes less than 1 minute (or some time limit). http://gerrit.cloudera.org:8080/#/c/14012/1/tests/query_test/test_exprs.py@167 PS1, Line 167: test_statement_expression_limit Same here, assert that this takes less than 1 minute (or whatever). -- To view, visit http://gerrit.cloudera.org:8080/14012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5675fb4a08c1dc51ae5bcf467cbb969cc064602c Gerrit-Change-Number: 14012 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Aug 2019 22:45:26 +0000 Gerrit-HasComments: Yes
