Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 )
Change subject: IMPALA-8637: Implement transaction handling and locking for ACID queries ...................................................................... Patch Set 10: Code-Review+2 (4 comments) Thanks for upgrading the tests! I have some nits, otherwise it is ok for me. http://gerrit.cloudera.org:8080/#/c/13968/10/tests/query_test/test_acid.py File tests/query_test/test_acid.py: http://gerrit.cloudera.org:8080/#/c/13968/10/tests/query_test/test_acid.py@105 PS10, Line 105: latest_open_txn nit: I don't like the name too much, it made me assume that it is a txn id instead of a timestamp. E.g. last_open_txn_start_time would be more descriptive. http://gerrit.cloudera.org:8080/#/c/13968/10/tests/query_test/test_acid.py@111 PS10, Line 111: "insert into {} values (sleep(200000))".format(dummy_tbl)) nit: indent 4 http://gerrit.cloudera.org:8080/#/c/13968/10/tests/query_test/test_acid.py@121 PS10, Line 121: self.client.cancel(handle) Can we do it in a try: finally: block? If there is an exception for some reason this long running query could affect some other tests that use metrics. http://gerrit.cloudera.org:8080/#/c/13968/10/tests/query_test/test_acid.py@140 PS10, Line 140: _get_transactions nit: _get_impala_transactions would be more precise -- To view, visit http://gerrit.cloudera.org:8080/13968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa37899b24aa114be642bf8772b4e0f882865cfa Gerrit-Change-Number: 13968 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Aug 2019 17:09:05 +0000 Gerrit-HasComments: Yes
