Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13992 )
Change subject: IMPALA-8791: Handle the case where there is no fragment scheduled on the coordinator ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/admission-controller.cc@442 PS2, Line 442: && CanMemLimitAccommodateReservation( Nice to remove this special case. http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/query-schedule.h@81 PS2, Line 81: // Indicates whether this backend will run on the coordinator backend. nit: wording is a bit weird. Maybe just "Indicates whether this backend is the coordinator". http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/query-schedule.h@374 PS2, Line 374: requiresCoordinatorFragment nit: RequiresCoordinatorFragment() http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/query-schedule.cc File be/src/scheduling/query-schedule.cc: http://gerrit.cloudera.org:8080/#/c/13992/2/be/src/scheduling/query-schedule.cc@261 PS2, Line 261: only_coord_fragment_schduled scheduled? -- To view, visit http://gerrit.cloudera.org:8080/13992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5631fa1490d9612ffac3c4c4715348de47d6df2 Gerrit-Change-Number: 13992 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Aug 2019 23:45:20 +0000 Gerrit-HasComments: Yes
