Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14042
Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put ...................................................................... IMPALA-8846: Undefined behaviour in RleEncoder::Put To test for overflow, we used 'repeat_count_ <= std::numeric_limits<int32_t>::max()', but this is always true as repeat_count_ is an int. This could have lead to undefined behaviour because we increment repeat_count_ afterwards. Changed the comparison not to allow equality. Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613 --- M be/src/util/rle-encoding.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/14042/1 -- To view, visit http://gerrit.cloudera.org:8080/14042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I269443d1f1680e672fde7dd88eab5fcb56c65613 Gerrit-Change-Number: 14042 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
