Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14044 )

Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:

http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@84
PS1, Line 84:  If the <varname>expression</varname> value is of a type that 
cannot be converted to
            :             the target <varname>type</varname>, e.g. from 
<codeph>TIMESTAMP</codeph> to
            :             <codeph>DECIMAL</codeph>, the function returns 
<codeph>NULL</codeph>.
DECIMAL and DATE types are exceptions to this rule: they return an error 
instead.

impala> select cast('123x' as decimal);
ERROR: UDF ERROR: String to Decimal parse failed


http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@175
PS1, Line 175: TIMESTAMP
This should be DATE too, if in L176 the expected result is of DATE type.


http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@528
PS1, Line 528: -15 and 15
I'm not sure if this is the valid range. Please check with Gabor Kaszab.


http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@555
PS1, Line 555: 0 and 59
I'm not sure if this is the valid range. Please check with Gabor Kaszab.



--
To view, visit http://gerrit.cloudera.org:8080/14044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092
Gerrit-Change-Number: 14044
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 16:27:30 +0000
Gerrit-HasComments: Yes

Reply via email to