Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 )
Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@545 PS3, Line 545: int num_remote_executor_candidates = query_options.num_remote_executor_candidates; : if (executor_group.NumExecutors() < num_remote_executor_candidates) { : num_remote_executor_candidates = executor_group.NumExecutors(); : } > nit: use std::min Done http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@802 PS3, Line 802: 8 > It seems clearer if we define this constant as a constant variable. Turned this into a static const http://gerrit.cloudera.org:8080/#/c/14026/3/be/src/scheduling/scheduler.cc@811 PS3, Line 811: if (candidates_it == remote_executor_candidates->end()) { > My thinking was that when n is small, maintaining one structure (even thoug Changed this to use a set (like before), but to put the IpAddrs directly in the vector rather than getting them from the set. -- To view, visit http://gerrit.cloudera.org:8080/14026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfdb2cc53d7206e316ea8a1cc28ad443f246f741 Gerrit-Change-Number: 14026 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Aug 2019 06:15:20 +0000 Gerrit-HasComments: Yes
