Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14038 )
Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables ...................................................................... IMPALA-8823: DROP TABLE support for insert-only ACID tables Enhances Impala to be able to drop insert-only transactional tables. In order to do this Impala acquires an exclusive table lock in HMS before performing the drop operation and releases the lock once dropping the table finished. INSERT statement does the locking and heartbeating on coordinator side but for DROP TABLE all of these are done from Catalog side. This means that alongside Impala coordinators now Catalog also does heartbeating towards HMS. Testing: - E2E test: Dropped a table, re-created it and dropped again to check if no locks remained in HMS. - E2E test: After dropping a table from Impala checked if Hive also sees it being dropped. - Manual test: With a hacked Impala that runs a drop table long enough I checked that there is a table lock entry in HMS during the execution and disappears once the query finishes. Change-Id: Ic41ca73268c4b75af5a08fe3dd1ada1df3f6fd34 Reviewed-on: http://gerrit.cloudera.org:8080/14038 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java R fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/workloads/functional-query/queries/QueryTest/acid.test M tests/metadata/test_hms_integration.py M tests/query_test/test_acid.py 11 files changed, 205 insertions(+), 40 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic41ca73268c4b75af5a08fe3dd1ada1df3f6fd34 Gerrit-Change-Number: 14038 Gerrit-PatchSet: 13 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
