Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14096


Change subject: WIP: IMPALA-7027: fix StringLiteral.localEquals()
......................................................................

WIP: IMPALA-7027: fix StringLiteral.localEquals()

String literals with the same value but different types
are not interchangeable. localEquals() should check
the type, similar to a cast expression.

Testing:
TODO
- Add some targeted tests with various string literals in select list,
  including CHAR and VARCHAR
- Run exhaustive tests (need to make sure this doesn't regress anything)

Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138
---
M fe/src/main/java/org/apache/impala/analysis/StringLiteral.java
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14096/1
--
To view, visit http://gerrit.cloudera.org:8080/14096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a9dff514c2c4cc422343d1dfbd881917acca138
Gerrit-Change-Number: 14096
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>

Reply via email to