radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 )
Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/13748/18/be/src/util/hook-metrics.cc File be/src/util/hook-metrics.cc: http://gerrit.cloudera.org:8080/#/c/13748/18/be/src/util/hook-metrics.cc@82 PS18, Line 82: void QueryEventHookMetricContainer::Update(const TQueryEventHookMetrics& from) { Is this all I really have to do to make sure the metrics will be published? -- To view, visit http://gerrit.cloudera.org:8080/13748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb88422f7cfe86947d11ce57d2b4c63e57d1b643 Gerrit-Change-Number: 13748 Gerrit-PatchSet: 18 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fre...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Mon, 19 Aug 2019 22:16:07 +0000 Gerrit-HasComments: Yes