Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14131/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/14131/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@89 PS1, Line 89: * Cardinality for aggregatoins. Oops, need to fix this typo in next PS. http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test File testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test: http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@106 PS1, Line 106: # cardinality. input cardinality http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@144 PS1, Line 144: # aggregation classes. Should note that there's a bug here where aggregation classes are double-counted. -- To view, visit http://gerrit.cloudera.org:8080/14131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1 Gerrit-Change-Number: 14131 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Aug 2019 23:47:35 +0000 Gerrit-HasComments: Yes
