Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 )
Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14071/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14071/5//COMMIT_MSG@10 PS5, Line 10: it : just creates new empty ACID base directories. > Can you mention the _empty file + that this is the same as the way Hive wor Extended the commit message. http://gerrit.cloudera.org:8080/#/c/14071/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14071/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1912 PS5, Line 1912: _empty > It would be nice to mention that Hive works the same way + maybe add a the Added link to the IMPALA Jira, I don't know the exact Hive Jira when they introduced _orc_acid_version. Hive uses this file differently than we use this "_empty" file. It creates the magic file in every transactional directory and as its name suggests it stores the ACID version being used. I'm not sure that it is a good idea to comment about Hive's behavior here because it could be distracting. -- To view, visit http://gerrit.cloudera.org:8080/14071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic749b7f27da157e1c0ebf9b7e9b6ee09afad122a Gerrit-Change-Number: 14071 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dinesh Garg (430) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 15:57:34 +0000 Gerrit-HasComments: Yes
