Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13 PS1, Line 13: 'impala-server.ready' metric. > One thing I didn't think about was authentication - is it gonna be messy en Thats a good point. Do you think we should add a webserver in this patch or defer to a subsequent change? An alternative might be to pull some callbacks inside BeginRequestCallback() in front of HandleSpnego() and skip authentication checks (/healthz should be fine for any user to access). http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc@179 PS1, Line 179: (*data) << "OK"; > It feels wrong to me that we're not setting *response - I guess the caller Done http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14146/1/tests/webserver/test_web_pages.py@658 PS1, Line 658: > flake8: W391 blank line at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/14146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615 Gerrit-Change-Number: 14146 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Aug 2019 15:57:27 +0000 Gerrit-HasComments: Yes
