Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 )
Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state-test.cc File be/src/runtime/coordinator-backend-state-test.cc: http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state-test.cc@40 PS1, Line 40: > nit: should be a ** according to style guide Done http://gerrit.cloudera.org:8080/#/c/14104/1/be/src/runtime/coordinator-backend-state-test.cc@52 PS1, Line 52: > nit: ++i according to google style guide Done http://gerrit.cloudera.org:8080/#/c/14104/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/14104/2/be/src/runtime/coordinator-backend-state.cc@807 PS2, Line 807: schedule_(schedule), > I think we can merge this into the constructor, since there's nothing that Done http://gerrit.cloudera.org:8080/#/c/14104/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/14104/2/be/src/scheduling/admission-controller.cc@992 PS2, Line 992: } > nit: We could use the released_backends iterator instead of looking it up a Done -- To view, visit http://gerrit.cloudera.org:8080/14104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bb11e0ede7574568020e0277dd8ac8d2586dc9 Gerrit-Change-Number: 14104 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Aug 2019 22:54:37 +0000 Gerrit-HasComments: Yes
