Hello Quanlong Huang, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14119
to look at the new patch set (#5).
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
......................................................................
IMPALA-8879: upgrade bootstrap for debug page to 4.3.1
Also upgrade DataTables to 1.10.18 at the same time..
They were obtained from https://datatables.net/download/
and https://getbootstrap.com/docs/4.3/getting-started/download/.
Included the version number in the css and js filenames to
avoid potential issues with stale versions being cached
(I got tripped up by this).
I had to do some additional work to get the UI to look right
after the upgrade:
* added additional style classes to HTML elements for nav and
breadcrumb styles - these are required in bootstrap 4.
* added styling for plan visualisation graph for it to
appear similar to the old graph.
* Added styling for <pre> to get box around text.
Testing:
Manually clicked through the web UI to see if anything looked
wrong or didn't function correctly.
Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
---
M .gitattributes
M bin/rat_exclude_files.txt
D www/DataTables-1.10.12/css/dataTables.bootstrap.min.css
D www/DataTables-1.10.12/css/dataTables.foundation.min.css
D www/DataTables-1.10.12/css/dataTables.jqueryui.min.css
D www/DataTables-1.10.12/css/jquery.dataTables.min.css
D www/DataTables-1.10.12/css/jquery.dataTables_themeroller.css
D www/DataTables-1.10.12/js/dataTables.foundation.min.js
D www/DataTables-1.10.12/js/jquery.dataTables.min.js
R www/DataTables-1.10.18/css/dataTables.bootstrap.css
A www/DataTables-1.10.18/css/dataTables.bootstrap.min.css
C www/DataTables-1.10.18/css/dataTables.bootstrap4.css
A www/DataTables-1.10.18/css/dataTables.bootstrap4.min.css
R www/DataTables-1.10.18/css/dataTables.foundation.css
A www/DataTables-1.10.18/css/dataTables.foundation.min.css
R www/DataTables-1.10.18/css/dataTables.jqueryui.css
A www/DataTables-1.10.18/css/dataTables.jqueryui.min.css
A www/DataTables-1.10.18/css/dataTables.semanticui.css
A www/DataTables-1.10.18/css/dataTables.semanticui.min.css
R www/DataTables-1.10.18/css/jquery.dataTables.css
A www/DataTables-1.10.18/css/jquery.dataTables.min.css
R www/DataTables-1.10.18/images/sort_asc.png
R www/DataTables-1.10.18/images/sort_asc_disabled.png
R www/DataTables-1.10.18/images/sort_both.png
R www/DataTables-1.10.18/images/sort_desc.png
R www/DataTables-1.10.18/images/sort_desc_disabled.png
R www/DataTables-1.10.18/js/dataTables.bootstrap.js
R www/DataTables-1.10.18/js/dataTables.bootstrap.min.js
C www/DataTables-1.10.18/js/dataTables.bootstrap4.js
A www/DataTables-1.10.18/js/dataTables.bootstrap4.min.js
R www/DataTables-1.10.18/js/dataTables.foundation.js
A www/DataTables-1.10.18/js/dataTables.foundation.min.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.js
R www/DataTables-1.10.18/js/dataTables.jqueryui.min.js
C www/DataTables-1.10.18/js/dataTables.semanticui.js
A www/DataTables-1.10.18/js/dataTables.semanticui.min.js
R www/DataTables-1.10.18/js/jquery.dataTables.js
A www/DataTables-1.10.18/js/jquery.dataTables.min.js
M www/all_child_groups.tmpl
A www/bootstrap/css/bootstrap-4.3.1.min.css
D www/bootstrap/css/bootstrap-theme.css
D www/bootstrap/css/bootstrap-theme.css.map
D www/bootstrap/css/bootstrap-theme.min.css
D www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.css
M www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
M www/bootstrap/css/bootstrap.min.css.map
D www/bootstrap/fonts/glyphicons-halflings-regular.eot
D www/bootstrap/fonts/glyphicons-halflings-regular.svg
D www/bootstrap/fonts/glyphicons-halflings-regular.ttf
D www/bootstrap/fonts/glyphicons-halflings-regular.woff
D www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap-4.3.1.min.js
M www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
M www/catalog.tmpl
M www/common-header.tmpl
R www/datatables-1.10.18.css
C www/datatables-1.10.18.js
A www/datatables-1.10.18.min.css
A www/datatables-1.10.18.min.js
D www/datatables.js
D www/datatables.min.css
D www/datatables.min.js
M www/metrics.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_stmt.tmpl
M www/threadz_tabs.tmpl
70 files changed, 15,464 insertions(+), 37,440 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14119/5
--
To view, visit http://gerrit.cloudera.org:8080/14119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7
Gerrit-Change-Number: 14119
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
