Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14169 )
Change subject: IMPALA-8913: Add query option to disable hbase row estimation ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14169/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/14169/1/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@331 PS1, Line 331: cardinality_ *= computeSelectivity(); > That seems bad! If it's -1 we want to keep it as -1 so that upstream plan n Understand it. cardinality_ == -1 means unknown rows. We should not change it to other values here. Will add more checks here. -- To view, visit http://gerrit.cloudera.org:8080/14169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I768ea1f560c5faab74d8772bc8aa9ddefdcf2e10 Gerrit-Change-Number: 14169 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Sep 2019 07:43:03 +0000 Gerrit-HasComments: Yes
