Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 )
Change subject: IMPALA-8755: Frontend support for Z-ordering ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/13955/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13955/9//COMMIT_MSG@30 PS9, Line 30: > hmm, indeed, unlock_zorder_sort would be slightly better. (nit) Done http://gerrit.cloudera.org:8080/#/c/13955/9/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: http://gerrit.cloudera.org:8080/#/c/13955/9/fe/src/main/java/org/apache/impala/analysis/TableDef.java@397 PS9, Line 397: throw new AnalysisException(String.format("SORT BY ZORDER does not support " : + "column type: %s", colType.toSql())); > Hmm, It might be more usable if you printed out all the unsupported columns Sounds good, will change it that way. -- To view, visit http://gerrit.cloudera.org:8080/13955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie122002ca8f52ca2c1e1ec8ff1d476ae1f4f875d Gerrit-Change-Number: 13955 Gerrit-PatchSet: 11 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Sep 2019 10:29:47 +0000 Gerrit-HasComments: Yes
